Skip to content

[CodeStyle][F401] remove unused imports in unittest/asp, autograd, interpreter - #46376

Merged
luotao1 merged 1 commit into
PaddlePaddle:developfrom
cattidea:F401/fix/ut
Sep 29, 2022
Merged

[CodeStyle][F401] remove unused imports in unittest/asp, autograd, interpreter#46376
luotao1 merged 1 commit into
PaddlePaddle:developfrom
cattidea:F401/fix/ut

Conversation

@SigureMo

@SigureMo SigureMo commented Sep 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR types

Others

PR changes

Others

Describe

修复 F401 unused import 存量 python 代码

初步尝试一些可行性，isort 目前配置还是会和 yapf 有冲突，需要再调整下（目前参考 ESMValGroup/ESMValCore#777 和 google/yapf#347 ）

# autoflake, remove unused imports
autoflake --in-place --remove-all-unused-imports ./python/paddle/fluid/tests/unittests/asp/**/*.py

# isort, sort imports
isort ./python/paddle/fluid/tests/unittests/asp/

# remove-future-import, remove some python2 `from __future__ import xxx` code
remove-future-import ./python/paddle/fluid/tests/unittests/asp/**/*.py

isort 应可解决 E401（multiple imports on one line）

仅仅修复 F401，无 remove-future-import 和 isort，这个 PR 之后会作为示例 PR

autoflake --in-place --remove-all-unused-imports --exclude=__init__.py --recursive ./python/paddle/fluid/tests/unittests/asp/
autoflake --in-place --remove-all-unused-imports --exclude=__init__.py --recursive ./python/paddle/fluid/tests/unittests/autograd/
autoflake --in-place --remove-all-unused-imports --exclude=__init__.py --recursive ./python/paddle/fluid/tests/unittests/interpreter/

@paddle-bot

paddle-bot Bot commented Sep 21, 2022

Copy link
Copy Markdown

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added contributor External developers status: proposed labels Sep 21, 2022
@SigureMo SigureMo changed the title [WIP][CodeStyle][F401] remove unused imports in unittest [WIP][CodeStyle][F401] remove unused imports in unittest (fluid/tests/unittests/asp) Sep 21, 2022
@luotao1 luotao1 self-assigned this Sep 22, 2022
@luotao1

luotao1 commented Sep 22, 2022

Copy link
Copy Markdown
Collaborator

和 @SigureMo 讨论：

  • remove-future-import：能删除python2.7的代码，可以单独作为一个项目来。这个风险较小，可以试试一个PR来修。
  • isort：可以尝试修复全量，是否有CI不过的情况，如果没有，可以一次性修复。

@SigureMo SigureMo mentioned this pull request Sep 23, 2022
Closed
@SigureMo SigureMo changed the title [WIP][CodeStyle][F401] remove unused imports in unittest (fluid/tests/unittests/asp) [CodeStyle][F401] remove unused imports in unittest (fluid/tests/unittests/asp) Sep 28, 2022
@SigureMo SigureMo changed the title [CodeStyle][F401] remove unused imports in unittest (fluid/tests/unittests/asp) [CodeStyle][F401] remove unused imports in unittest/asp, autograd, interpreter Sep 28, 2022
@SigureMo SigureMo mentioned this pull request Sep 28, 2022
Merged
luotao1
luotao1 approved these changes Sep 29, 2022
View reviewed changes

@luotao1 luotao1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
luotao1 merged commit f603992 into PaddlePaddle:develop Sep 29, 2022
@SigureMo
SigureMo deleted the F401/fix/ut branch September 29, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@luotao1 luotao1 luotao1 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@luotao1 luotao1

Labels

contributor External developers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[F401] python/paddle/fluid/tests/unittests/autograd [F401] python/paddle/fluid/tests/unittests/interpreter + python/paddle/fluid/tests/unittests/asp

2 participants

@SigureMo @luotao1